Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change admin endpoint name #5447

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Change admin endpoint name #5447

merged 7 commits into from
Sep 14, 2023

Conversation

ndmlny-qs
Copy link
Contributor

@ndmlny-qs ndmlny-qs commented Aug 25, 2023 •
edited
Loading

Resolves #5370
Resolves #3179

@ndmlny-qs ndmlny-qs marked this pull request as draft August 25, 2023 17:15
@ndmlny-qs ndmlny-qs mentioned this pull request Aug 25, 2023
Closed
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #5447 (06aa426) into main (ff43d36) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 24.13%.

@@            Coverage Diff             @@
##             main    #5447      +/-   ##
==========================================
+ Coverage   83.55%   83.57%   +0.02%     
==========================================
  Files         276      276              
  Lines       40147    40180      +33     
==========================================
+ Hits        33543    33582      +39     
+ Misses       6604     6598       -6
Flag Coverage Δ
ui-tests 41.36% <24.13%> (+<0.01%) ⬆️
unitexamples-tests 72.53% <24.13%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/command/serve.py 39.54% <0.00%> (-0.62%) ⬇️
panel/tests/command/test_serve.py 23.94% <20.00%> (-1.55%) ⬇️
panel/config.py 70.20% <75.00%> (+0.04%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

philippjfr
philippjfr reviewed Sep 11, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
@ndmlny-qs
[WIP] Change admin panel name
78a51be
@ndmlny-qs
Address PR comments
44f288c 
This commit address the following, as well as rebasing off of main.

- Change `admin-path-name` to `admin-endpoint` to better align with the
  codebase.
- Create a new section in the profiling documentation to show how to use
  the new command line flag `--admin-endpoint=...`.
@ndmlny-qs ndmlny-qs force-pushed the issue5370/admin-path-name branch from 3267382 to 44f288c Compare September 11, 2023 16:28
@ndmlny-qs
Copy link
Contributor Author

Added documentation to profiling/admin.md as well.

I'm going to keep this PR in a [WIP] state for now. The ability to change the name of the admin endpoint does not prevent other users from seeing it when they are logged in, it just obfuscates where the admin endpoint is. I can't entirely work out the data flow for how the admin page is created, but it doesn't seem to be going through the DocHandler.get method, otherwise PR #5386 would prevent a non-authorized user from seeing the renamed admin page.

@ndmlny-qs
Copy link
Contributor Author

switching from WIP to a PR

@ndmlny-qs ndmlny-qs marked this pull request as ready for review September 13, 2023 13:35
@ndmlny-qs ndmlny-qs changed the title [WIP] Change admin panel name Change admin endpoint name Sep 13, 2023
@ndmlny-qs ndmlny-qs mentioned this pull request Sep 13, 2023
Closed
philippjfr
philippjfr reviewed Sep 13, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
philippjfr
philippjfr reviewed Sep 13, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
philippjfr
philippjfr reviewed Sep 13, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
philippjfr
philippjfr reviewed Sep 13, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
philippjfr
philippjfr reviewed Sep 13, 2023
View reviewed changes
panel/command/serve.py Outdated Show resolved Hide resolved
philippjfr
philippjfr approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, took the liberty to make some minor changes and add some tests.

@philippjfr philippjfr merged commit 23550b2 into holoviz:main Sep 14, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only allow certain users to see Admin panel Enable serving admin site at custom and secure url
2 participants
@ndmlny-qs @philippjfr